2.1.1 — MCP Phase 0: every high-level op returns an envelope (return-not-print)

Internal refactor per docs/MCP-SERVER-SPEC.md §4; CLI output and exit codes
unchanged (wrappers reproduce them from the envelopes):

- echo_ops: capture_op/resolve_op/link_op — duplicate gate and offline queueing
  are data (action: duplicate-gate + candidates; queued: true); the --json
  stdout-swallow hack is deleted (helper chatter -> stderr inside the cores);
  capture_op takes body_text= directly (the MCP path, no temp file).
- echo_recall.recall_op — one structured result backs prose and --json.
- echo_triage.list_op/route_op, echo_reflect.apply_op,
  echo_session.session_end_op — call capture_op internally, count gate outcomes
  from envelopes.
- echo.scope_show_op/scope_set_op/load_op (+ shared _load_gather), and
  echo_doctor.run_op (checks as data).

New eval/test_ops_api.py asserts the contract for every core: envelope shape
AND stdout purity (a stray print would corrupt an MCP response stream). All six
suites green. The 2.2 server build now starts directly at the app layer.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

echo-memory.plugin.src/skills/echo-memory/scripts/echo_doctor.py

@@ -22,17 +22,18 @@ import echo  # noqa: E402
 MIN_PY = (3, 9)
 
 
-def run() -> int:
-    reds = 0
+def run_op() -> dict:
+    """Core doctor (Phase 0): the readiness checks as data — {checks: [{ok, label,
+    detail}], endpoint, fatal, ok}. `fatal` names an early-exit condition (not
+    configured / unreachable) after which later checks were skipped."""
+    checks: list[dict] = []
 
     def line(ok: bool, label: str, detail: str = "") -> None:
-        nonlocal reds
-        reds += 0 if ok else 1
-        print(f"  [{'OK ' if ok else 'RED'}] {label}" + (f" — {detail}" if detail else ""))
+        checks.append({"ok": ok, "label": label, "detail": detail})
 
     import echo_config
     cfg = echo_config.load()
-    print(f"echo doctor — endpoint {cfg['endpoint'] or '(not configured)'}")
+    fatal = None
 
     # 1. interpreter
     line(sys.version_info >= MIN_PY, f"python >= {MIN_PY[0]}.{MIN_PY[1]}",
@@ -53,33 +54,50 @@ def run() -> int:
     line(bool(cfg["owner"]), "vault owner set",
          cfg["owner"] if cfg["owner"] else "optional, but recommended for third-person writes")
     if not echo_config.is_configured(cfg):
+        fatal = "not-configured"
+    else:
+        # 3. reachability + auth + marker, in one GET of the bootstrap marker
+        status, body = echo.request("GET", echo.vault_url("_agent/echo-vault.md"))
+        if status == 0:
+            line(False, "vault reachable", body.decode(errors="replace")[:120])
+            fatal = "unreachable"
+        else:
+            line(status not in (401, 403), "auth accepted",
+                 f"HTTP {status}" if status in (401, 403) else "")
+            if status == 404:
+                line(False, "vault bootstrapped", "marker absent — run bootstrap.py")
+            elif status == 200:
+                text = body.decode(errors="replace")
+                ver = next((ln.split(":", 1)[1].strip() for ln in text.splitlines()
+                            if ln.startswith("schema_version:")), "?")
+                line(True, "vault bootstrapped", f"schema_version={ver}")
+            else:
+                line(status < 400, "marker fetch", f"HTTP {status}")
+
+    reds = sum(1 for c in checks if not c["ok"])
+    return {"ok": reds == 0 and fatal is None, "action": "doctor",
+            "endpoint": cfg["endpoint"], "fatal": fatal, "reds": reds, "checks": checks}
+
+
+def run() -> int:
+    env = run_op()
+    print(f"echo doctor — endpoint {env['endpoint'] or '(not configured)'}")
+    for c in env["checks"]:
+        print(f"  [{'OK ' if c['ok'] else 'RED'}] {c['label']}"
+              + (f" — {c['detail']}" if c["detail"] else ""))
+    if env["fatal"] == "not-configured":
         print("\ndoctor: not configured — ask the operator for their key file and install it "
               "(`echo.py config import <file>`, or `config set --owner … --endpoint … --key …`), "
               "then re-run.")
         return 1
-
-    # 3. reachability + auth + marker, in one GET of the bootstrap marker
-    status, body = echo.request("GET", echo.vault_url("_agent/echo-vault.md"))
-    if status == 0:
-        line(False, "vault reachable", body.decode(errors="replace")[:120])
+    if env["fatal"] == "unreachable":
         print("\ndoctor: endpoint unreachable — is Obsidian + the Local REST API running?")
         return 1
-    line(status not in (401, 403), "auth accepted", f"HTTP {status}" if status in (401, 403) else "")
-    if status == 404:
-        line(False, "vault bootstrapped", "marker absent — run bootstrap.py")
-    elif status == 200:
-        text = body.decode(errors="replace")
-        ver = next((ln.split(":", 1)[1].strip() for ln in text.splitlines()
-                    if ln.startswith("schema_version:")), "?")
-        line(True, "vault bootstrapped", f"schema_version={ver}")
-    else:
-        line(status < 400, "marker fetch", f"HTTP {status}")
-
-    # 4. invariants pointer.
+    # invariants pointer.
     print("  [i] invariants — run `/echo-health` (vault_lint.py) for the full check")
-
-    print(f"\ndoctor: {'all green' if reds == 0 else f'{reds} issue(s) — see RED above'}")
-    return 1 if reds else 0
+    summary = "all green" if env["reds"] == 0 else f"{env['reds']} issue(s) — see RED above"
+    print(f"\ndoctor: {summary}")
+    return 1 if env["reds"] else 0
 
 
 if __name__ == "__main__":