From 0e7c2a231862db09b8534f835cac3a9873bf88f1 Mon Sep 17 00:00:00 2001 From: mickey-mikey <149929346+mickey-mikey@users.noreply.github.com> Date: Wed, 4 Mar 2026 16:47:29 +1100 Subject: [PATCH] refactor: move test_tasks_manage_is_valid_level to TestParsePermissionsArg Addresses CodeRabbit Review 4 nitpick: the test validates parse_permissions_arg() so it belongs with that test class. Co-Authored-By: Claude Opus 4.6 --- tests/test_permissions.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/test_permissions.py b/tests/test_permissions.py index 51d3c7e..f88ee7c 100644 --- a/tests/test_permissions.py +++ b/tests/test_permissions.py @@ -73,6 +73,11 @@ class TestParsePermissionsArg: with pytest.raises(ValueError, match="Unknown level"): parse_permissions_arg(["gmail:read:only"]) + def test_tasks_manage_is_valid_level(self): + """tasks:manage should be accepted by parse_permissions_arg.""" + result = parse_permissions_arg(["tasks:manage"]) + assert result == {"tasks": "manage"} + class TestGetScopesForPermission: """Tests for get_scopes_for_permission() cumulative scope expansion.""" @@ -134,10 +139,6 @@ class TestGetScopesForPermission: assert TASKS_SCOPE in scopes assert TASKS_READONLY_SCOPE in scopes - def test_tasks_manage_is_valid_level(self): - """tasks:manage should be accepted by parse_permissions_arg.""" - result = parse_permissions_arg(["tasks:manage"]) - assert result == {"tasks": "manage"} @pytest.fixture(autouse=True)