fix(searcher): guard against empty ChromaDB query results (#195) (#865)

Fixes #195.

When ChromaDB returns no documents (empty palace, or wing/room filter
that excludes everything), it returns the shape:

    {"documents": [], "metadatas": [], "distances": []}

Indexing `results["documents"][0]` blindly raises IndexError instead of
the expected 'no results' response. Affected: searcher.search(),
searcher.search_memories() (drawer + closet branches plus the
total_before_filter aggregate), and Layer3.search() / Layer3.search_raw().

Adds a tiny private helper `searcher._first_or_empty(results, key)` that
safely extracts the inner list, returning [] for any of: missing key,
empty outer list, [None], or [[]]. layers.py imports the same helper to
avoid duplicating the guard.

Tests: tests/test_empty_chromadb_results.py covers all observed shapes
plus a documentation-style test that pins the original IndexError so
future readers understand why the helper exists.
This commit is contained in:
Arnold Wender
2026-04-15 09:26:38 +02:00
committed by GitHub
parent 54a386d925
commit 6a73eb2e20
3 changed files with 79 additions and 17 deletions
+7 -7
View File
@@ -23,7 +23,7 @@ from collections import defaultdict
from .config import MempalaceConfig
from .palace import get_collection as _get_collection
from .searcher import build_where_filter
from .searcher import _first_or_empty, build_where_filter
# ---------------------------------------------------------------------------
@@ -272,9 +272,9 @@ class Layer3:
except Exception as e:
return f"Search error: {e}"
docs = results["documents"][0]
metas = results["metadatas"][0]
dists = results["distances"][0]
docs = _first_or_empty(results, "documents")
metas = _first_or_empty(results, "metadatas")
dists = _first_or_empty(results, "distances")
if not docs:
return "No results found."
@@ -323,9 +323,9 @@ class Layer3:
hits = []
for doc, meta, dist in zip(
results["documents"][0],
results["metadatas"][0],
results["distances"][0],
_first_or_empty(results, "documents"),
_first_or_empty(results, "metadatas"),
_first_or_empty(results, "distances"),
):
hits.append(
{