fix: restrict file permissions on sensitive palace data (#814)

* fix: restrict file permissions on sensitive palace data

On Linux with default umask (022), several files and directories
containing personal data were created world-readable. This patch
applies chmod 0o700 to directories and 0o600 to files immediately
after creation, wrapped in try/except for Windows compatibility.

Files hardened:
- hooks_cli.py: hook_state/ directory and hook.log
- entity_registry.py: entity_registry.json (names, relationships)
- knowledge_graph.py: knowledge_graph.sqlite3 parent directory
- exporter.py: export output directory and wing subdirectories
- config.py: people_map.json (name mappings)
- mcp_server.py: WAL file creation uses atomic os.open (TOCTOU fix)

Refs: MemPalace/mempalace#809

* fix: avoid redundant chmod calls on hot paths

- hooks_cli.py: chmod STATE_DIR and hook.log only on first creation,
  not on every _log() call (hooks fire on every Stop event)
- exporter.py: track created wing dirs to skip redundant makedirs +
  chmod on the same directory across batches
- mcp_server.py: remove redundant _WAL_FILE.chmod after os.open
  already set mode=0o600 atomically

Refs: MemPalace/mempalace#809

This commit is contained in:

Marcio E. Heiderscheidt

2026-04-15 04:27:03 -03:00

committed by

GitHub

parent e61dc2adf8

commit b524b31839

6 changed files with 56 additions and 11 deletions

									
										mempalace/config.py
									
		+4
		
												View File
												
				@@ -251,4 +251,8 @@ class MempalaceConfig:

				        self._config_dir.mkdir(parents=True, exist_ok=True)

				        with open(self._people_map_file, "w") as f:

				            json.dump(people_map, f, indent=2)

				        try:

				            self._people_map_file.chmod(0o600)

				        except (OSError, NotImplementedError):

				            pass

				        return self._people_map_file