refactor: move test_tasks_manage_is_valid_level to TestParsePermissionsArg

Addresses CodeRabbit Review 4 nitpick: the test validates
parse_permissions_arg() so it belongs with that test class.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
mickey-mikey
2026-03-04 16:47:29 +11:00
parent acc3e665d0
commit 0e7c2a2318

View File

@@ -73,6 +73,11 @@ class TestParsePermissionsArg:
with pytest.raises(ValueError, match="Unknown level"): with pytest.raises(ValueError, match="Unknown level"):
parse_permissions_arg(["gmail:read:only"]) parse_permissions_arg(["gmail:read:only"])
def test_tasks_manage_is_valid_level(self):
"""tasks:manage should be accepted by parse_permissions_arg."""
result = parse_permissions_arg(["tasks:manage"])
assert result == {"tasks": "manage"}
class TestGetScopesForPermission: class TestGetScopesForPermission:
"""Tests for get_scopes_for_permission() cumulative scope expansion.""" """Tests for get_scopes_for_permission() cumulative scope expansion."""
@@ -134,10 +139,6 @@ class TestGetScopesForPermission:
assert TASKS_SCOPE in scopes assert TASKS_SCOPE in scopes
assert TASKS_READONLY_SCOPE in scopes assert TASKS_READONLY_SCOPE in scopes
def test_tasks_manage_is_valid_level(self):
"""tasks:manage should be accepted by parse_permissions_arg."""
result = parse_permissions_arg(["tasks:manage"])
assert result == {"tasks": "manage"}
@pytest.fixture(autouse=True) @pytest.fixture(autouse=True)