Merge pull request #987 from alpiua/fix-mcp-null-payload
fix(mcp): handle null JSON-RPC request payloads safely
This commit is contained in:
@@ -148,6 +148,20 @@ class TestHandleRequest:
|
||||
)
|
||||
assert resp["error"]["code"] == -32601
|
||||
|
||||
def test_tools_call_missing_params(self):
|
||||
from mempalace.mcp_server import handle_request
|
||||
|
||||
for bad_params in [None, {}, {"arguments": {}}]:
|
||||
resp = handle_request(
|
||||
{
|
||||
"method": "tools/call",
|
||||
"id": 15,
|
||||
"params": bad_params,
|
||||
}
|
||||
)
|
||||
assert resp["error"]["code"] == -32602
|
||||
assert "Invalid params" in resp["error"]["message"]
|
||||
|
||||
def test_unknown_method(self):
|
||||
from mempalace.mcp_server import handle_request
|
||||
|
||||
@@ -190,6 +204,17 @@ class TestHandleRequest:
|
||||
resp = handle_request({"method": None, "id": 99, "params": {}})
|
||||
assert resp["error"]["code"] == -32601
|
||||
|
||||
@pytest.mark.parametrize("payload", [None, [], "plain", 42, True])
|
||||
def test_handle_request_invalid_payload_returns_jsonrpc_error(self, payload):
|
||||
from mempalace.mcp_server import handle_request
|
||||
|
||||
resp = handle_request(payload)
|
||||
assert resp == {
|
||||
"jsonrpc": "2.0",
|
||||
"id": None,
|
||||
"error": {"code": -32600, "message": "Invalid Request"},
|
||||
}
|
||||
|
||||
def test_tools_call_dispatches(self, monkeypatch, config, palace_path, seeded_kg):
|
||||
_patch_mcp_server(monkeypatch, config, seeded_kg)
|
||||
from mempalace.mcp_server import handle_request
|
||||
|
||||
Reference in New Issue
Block a user